3x-ui/internal/web
Sanaei c8a3a2d723
fix(security): require a 2FA code to replace the stored TOTP secret
The confirmation gate in updateSetting only covered the true -> false
transition, so a settings save that kept twoFactorEnable=true while
carrying a non-blank twoFactorToken silently rebound the authenticator.
preserveRedactedSecrets restores the stored secret only when the
submitted one is blank, so a non-blank value went straight through
without any branch asking for a code.

Not reachable pre-auth or cross-site (CSRFMiddleware rejects unsafe
methods without the session token), but it matters after a session
hijack or with an admin API token, which sets api_authed and
short-circuits the CSRF check: the attacker gains persistence and locks
the legitimate operator out of their own authenticator.

Now a code is required whenever 2FA is currently on and the submitted
secret differs from the stored one. Enabling from off is untouched, as
no code exists yet to verify, and a blank secret still means
"unchanged", so the panel's normal save path is unaffected.

Reported by @n0ctal (GHSA-xqqw-jqqv-99h6).
2026-08-19 19:54:15 +02:00
..
controller fix(security): require a 2FA code to replace the stored TOTP secret 2026-08-19 19:54:15 +02:00
entity fix: follow-ups from the post-merge reviews of #6221, #6227, #6230 and #6239 (#6250) 2026-08-18 15:24:59 +02:00
global
job Add remote routing URL support (#6168) 2026-08-18 16:02:11 +02:00
locale
middleware
network fix(web): report unexpected HTTP serve failures (#6210) 2026-08-14 19:40:53 +02:00
runtime feat(inbound): DisableFlow — opt an inbound out of auto XTLS Vision (#5689) (#5698) 2026-08-15 23:09:16 +02:00
service Add remote routing URL support (#6168) 2026-08-18 16:02:11 +02:00
session
translation Add remote routing URL support (#6168) 2026-08-18 16:02:11 +02:00
websocket fix(nodes): keep the credential-presence flag on the node heartbeat push 2026-07-28 17:38:46 +02:00
cadence_test.go Add remote routing URL support (#6168) 2026-08-18 16:02:11 +02:00
routes_contract_test.go fix(api): authenticate GET /panel/api/openapi.json + pin the route registry to the router (#6133) 2026-07-29 08:00:05 +02:00
web.go Add remote routing URL support (#6168) 2026-08-18 16:02:11 +02:00
web_mtls.go
web_mtls_test.go