BulkResetTraffic resolved every address with its own GetRecordByEmail call, one SELECT per email, purely to find the disabled clients it has to re-enable. Resetting 30 clients issued 30 queries before the batched transaction even started, while BulkAdjust, BulkDelete and BulkSetEnable next to it already loaded their rows with a single chunked IN query. Those three carried a verbatim copy each of both the trim/dedupe loop and the chunked record load, so the reuse is the fix: trimmedUniqueEmails now delegates to the existing uniqueNonEmptyStrings, and clientRecordsByEmail holds the one chunked lookup all four call sites share. A DB failure during the lookup now aborts the reset instead of being swallowed per email; a missing row is still skipped, as before. The new test drives BulkResetTraffic with 3 and with 30 emails and fails unless both issue the same number of SELECTs against clients. |
||
|---|---|---|
| .. | ||
| amneziawg | ||
| amneziawgnet | ||
| config | ||
| crypto/nodetoken | ||
| database | ||
| eventbus | ||
| logger | ||
| mtproto | ||
| pia | ||
| sub | ||
| tunnelmonitor | ||
| util | ||
| web | ||
| xray | ||