3x-ui/.github
MHSanaei 532392850f fix(ci): drop id-token from the Claude workflows and tighten the review comment
CodeQL alert #121 flags the pr-head checkout in the PR review job. The
checkout is deliberate and nothing in the job executes it, but the job still
carried `id-token: write`, and so did the issue analyst. claude-code-action
only uses OIDC to trade for a Claude GitHub App token when no github_token is
passed - that app token asks for contents, pull_requests and issues write -
or for workload identity, which neither workflow uses. Both pass
github_token, so the permission did nothing for them, yet any code running
in either job could have minted that write token, undoing the review's
read-only split.

Three reviews posted on one morning (#6666, #6675, #6752) also showed rubric
gaps. REVIEW.md said both "open with the verdict" and "lead with No blocking
issues", so the comments opened three ways and two tallies dropped
severities; the opening is now a fixed order - tag line only when blocking,
verdict paragraph, one status line whose tally names all three severities.
#6675 filed a spoofable X-Forwarded-For IP, which that PR first shows to an
admin approving a login, under Design; Design now holds approaches and
trade-offs only, and a concrete consequence the change makes reachable or
worse is a finding. The coverage list ran to some 25 nested lines on #6752;
it is now ten lines at most, one per area, no nested bullets.
2026-10-12 13:39:29 +02:00
..
claude perf(tests): copy a migrated template DB instead of migrating per test 2026-09-27 03:04:50 +02:00
ISSUE_TEMPLATE fix(ci): resync the bot prompts with the repo and close the gaps an audit found 2026-08-17 02:41:21 +02:00
workflows fix(ci): drop id-token from the Claude workflows and tighten the review comment 2026-10-12 13:39:29 +02:00
dependabot.yml Security hardening: sessions, SSRF, CSP nonce, CSRF logout, trusted proxies (#4275) 2026-05-13 12:52:52 +02:00
FUNDING.yml chore(github): overhaul issue and PR templates 2026-05-24 22:14:28 +02:00
pull_request_template.md chore(github): overhaul issue and PR templates 2026-05-24 22:14:28 +02:00